[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] PATCH: Use name instead of pid in QEMU logs

On 12/6/07 15:59, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

> All domain names should be validated by XenD to contain printable characters
> only - they are displayed & used all over the place in numerous tools where
> having non-printale characters will cause plenty of trouble.
> 
> As for overwriting the log file with a domain autorestart after a crash, the
> logfile ought to be opened in append mode (w+ instead of w) - logrotate
> scripts can handle cleanup of logfiles
> 
> I am happy to submit further patches to validate domain names in XenD and
> switch to opening the file in append mode, if changeset 15219 were to be
> reverted.

Personally I don't much care either way. Christian didn't like the names in
log filenames, and he maintains the qemu patchset. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel