[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds
Keir Fraser wrote:
Oops. You're absolutely right. Both define pud_t, but nopud.h is definitely the correct one. Thanks for catching this ....In the patch it's pgtable-nopmd.h. But pgtable-nopud.h makes more sense (x86/64 Linux has always had proper pmds). So is the patch incorrect?
I tried that. But since the x86_64 hypervisor.h includes the i386 hypervisor.h, I have to put the conditional include of pgtable-nopud.h either before or after the include of i386 hypervisor.h, neither of which compiles on pre-2.6.11 kernels.Also, this could be placed inside asm-x86_64/mach-xen/asm/hypervisor.h, couldn't it? -- Keir
Dave _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our