[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] VMASST_TYPE_writable_pagetables on translated domains?

On 27/4/07 09:30, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Isn't the writeable page table support intended only for non-translated
> domains?
> If so, shouldn't fixup_page_fault() check for this, or the setting of the
> assist bit
> and the PG_translate be respectively validated? If not, aren't there bits
> missing
> in ptwr_do_page_fault()?

I think we've been here before. :-)

Current shadow code supports translated domains only in shadow-mode-refcount
configuration (which also implies shadow-mode-external, and hence hvm too,
as it happens).

In light of this there is quite some scope for simplification and
rationalisation in arch/x86/mm.c.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel