[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] Segments can span multiple clusters with tap:qcow
On Thu, 2007-04-26 at 11:00 +0100, Keir Fraser wrote: > On 26/4/07 10:18, "Mark McLoughlin" <markmc@xxxxxxxxxx> wrote: > > >> The current code allocates aio-request info for every segment in a request > >> ring (MAX_AIO_REQUESTS == BLK_RING_SIZE * MAX_SEGMENTS_PER_REQUEST). This > >> patch seems to take into account that each segment (part-of-page) can > >> itself > >> be split into clusters, hence the page_size/cluster_size calculation, but > >> shouldn't this be multiplied by the existing MAX_AIO_REQUESTS? Otherwise > >> you > >> provide only enough aio requests for one segment at a time, rather than a > >> request ring's worth of segments? > > > > Absolutely, well spotted. I fixed that typo after testing, but > > obviously forgot to run "quilt refresh" before sending ... > > > > Fixed version attached. > > This one doesn't build (free_aio_state: line 164: structure has no member > named 'private'). Perhaps free_aio_state() should take a 'struct > disk_driver' rather than a 'struct td_state'? Gah, merge error going from 3.0.4 to 3.0.5. This one builds. Thanks, Mark.
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our