[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log

On 24/4/07 23:15, "Aron Griffis" <aron@xxxxxx> wrote:

>>> Seems that the patch should be using 0666 instead of 0600 so that
>>> umask can affect group/other perms.  At the very least it should use
>>> 0664.
>> 
>> Xen-debug.log is the only file in /var/log/xen getting created with
>> +x permissions, so something is obviously up. Arguably we can get
>> rid of xend-debug.log entirely -- I don't believe anything ever gets
>> logged there these days. I took the patch because 0600 seems saner
>> than 0755.
> 
> It doesn't make any real difference to me, just thought I'd bring up
> the umask question before the patch was committed... though at this
> point it's in staging, so I guess I was too late. ;-)

You're probably right that one of 0644,0664,0666 is better. They're
certainly more in line with all other files under /var/log/xen.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel