[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] [libxc] add missing free in xc_finish_mmu_updates to avoid memory leak

On 6/4/07 14:45, "Stephan Creutz" <stephan.creutz@xxxxxxxxxxxxxxxxx> wrote:

> the following patch adds a missing free to xc_finish_mmu_updates,
> otherwise the memory allocated by xc_init_mmu_updates gets never freed.

The only user of this interface calls free() on that memory itself. It also
calls finish_mmu_update() more than once on the same mmu structure, so
freeing it in finish_mmu_update() would not work. Probably best we rename
xc_init_mmu_updates() to xc_alloc_mmu_updates(), finish_mmu_update to
flush_mmu_updates(), and document the need for explicit free() in the header
file. I'll do this.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel