[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH] XML-RPC: Cope with large integers on x86-64 systems
On Mon, Mar 27, 2006 at 08:29:13PM -0600, Anthony Liguori wrote:
> Attached patch fixes a problem in marshaling large integers. It seems
> to only occur on systems with very large memory. However, on those
> systems, it's a show-stopper. I see this as a temporary solution until
> we can sanitize the XML-RPC functions and get rid of all the
> S-Expression stuff.
This code is clearly plagiarised from Lib/xmlrpclib.py in the Python
distribution, without appropriate credit, copyright and licence statements in
the code, and without a patch to the documentation as per the licence
agreement. I can't accept this patch as it stands.
Regardless, I don't see what is to be gained in marshalling ints >32bits as
strings, but those <=32 bits as integers; the receiving code is going to have
to convert the incoming argument unconditionally, so why not just send all
integers as strings? They're going to be stringified on the wire anyway, so
there's no efficiency loss, and I don't think that anyone fancies auditing
Xend to figure out which integers are strict 32 bit integers on all platforms
and which aren't, so it would be safer just to pass them all as strings.
Xen-devel mailing list