[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [Xen-changelog] Added exception handler for ProtocolError.
Xen patchbot -unstable wrote:
# HG changeset patch # User emellor@xxxxxxxxxxxxxxxxxxxxxx # Node ID c1bb4eb565296bdb00aed84fcc877befbcebd8e9 # Parent b55ca95fdc846a5db9f30ba1c5d065fe898f88e7 Added exception handler for ProtocolError. Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx> diff -r b55ca95fdc84 -r c1bb4eb56529 tools/python/xen/xm/main.py --- a/tools/python/xen/xm/main.py Thu Mar 23 10:55:56 2006 +++ b/tools/python/xen/xm/main.py Thu Mar 23 10:58:19 2006 @@ -1102,6 +1102,12 @@ else: err("Error connecting to xend: %s." % ex) sys.exit(1) + except xmlrpclib.ProtocolError, ex: + if os.geteuid() != 0: + err("Most commands need root access. Please try again as root.") + else: + err("Error connecting to xend: %s." % ex.errmsg) + sys.exit(1) except SystemExit: sys.exit(1) except xmlrpclib.Fault, ex:
Hi Ewan,ProtocolError's shouldn't happen. The case where os.geteuid() != 0 is a possibility (although I thought we had a check earlier for that?). However, if we are getting them for another reason, something's wrong.
What commands were you seeing this with? There may be a latent bug in the dispatch code that marshals exceptions...
Regards, Anthony Liguori
_______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our