[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [patch] conditionalize building ACPI (was [RFC] build configuration)
On 18 Mar 2006, at 01:32, Hollis Blanchard wrote:
This patch fixes part of my current need: PPC doesn't want to build ACPI. Twobasic problems: one was xen/drivers/Makefile; the other was ALL_OBJS in xen/Rules.mk.While I was setting up ALL_OBJS-y for ACPI, I went ahead and converted the other users, and did the same for CFLAGS (though I really didn't have to).Note that this patch slightly changes the old behavior of "debug" and"verbose" in CFLAGS: before, if debug=y, verbose=y was set for you. Now you only get what you explicitly enable. Also, perf_array can be used outside of perfc. I don't consider either of these changes to be problematic, sincewhoever is building is already changing the config options.
Thanks, looks like the right approach. I'd like to continue down this track but leave any 'big bang' changes (like no recursive make in subdirectories) until after 3.0.2.
I wonder about getting rid of 'verbose' altogether -- I doubt anyone sets it independently of 'debug' and people are now used to just setting 'debug=y' on their build to get all the tracing and assertions we need to help them track down bugs. If there's no disagreement I'll make that change.
-- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our