Re: [Xen-devel] [PATCH] reiserfs module for pygrub

[Jeremy Katz <katzj@xxxxxxxxxx>]

On Tue, 2005-05-24 at 13:15 +0900, aq wrote:
> On 5/24/05, Jeremy Katz <katzj@xxxxxxxxxx> wrote:
> > On Tue, 2005-05-24 at 02:27 +0100, Ian Pratt wrote:
> > > > > The libraries get linked dynamically into the python module.  If at
> > > > > runtime, the library isn't present, it won't cause a fatal
> > > > error (you
> > > > > won't be able to access those types of filesystems, but it
> > > > won't fall
> > > > > over on the import)
> > > >
> > > > yes, this trick could be easily adapted to reiserfs and
> > > > others. but what if the user keeps the needed libraries, but
> > > > removes those headers ( like /usr/include/ext2fs/ext2_fs.h
> > > > )after building (for example to make the system more
> > > > compact)? then the check would fail.
> > >
> > > As I understand it, it's a build-time check for the header file
> > > (setup.py)
> > 
> > Exactly.
> > 
> 
> anyway, i sent in a check file for ext2 and reiserfs tools/check/
> check_fslibs_devel (which is filtered by accident, and i dont see it
> to be approved to the list yet?). so i doubt that we need to check
> (again) for header files in setup.py.

The question is whether we want all of the libraries to be mandatory or
not.  I'd lean towards them not being mandatory (ie, we build what you
have unless you specify an environment variable) instead of having them
all be required.

Jeremy


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel