[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] x86/domctl: further fix to XEN_DOMCTL_[gs]etvcpuextstate



commit 895661ae98f0249f50280b4acfb9dda70b76d7e9
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Tue Jun 10 12:03:16 2014 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Jun 10 12:03:16 2014 +0200

    x86/domctl: further fix to XEN_DOMCTL_[gs]etvcpuextstate
    
    Do not clobber errors from certain codepaths.  Clobbering of -EINVAL from
    failing "evc->size <= PV_XSAVE_SIZE(_xcr0_accum)" was a pre-existing bug.
    
    However, clobbering -EINVAL/-EFAULT from the get codepath was a bug
    unintentionally introduced by 090ca8c1 "x86/domctl: two functional fixes to
    XEN_DOMCTL_[gs]etvcpuextstate".
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/domctl.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 87af350..d927b59 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1277,8 +1277,6 @@ long arch_do_domctl(
             xfree(receive_buf);
         }
 
-        ret = 0;
-
     vcpuextstate_out:
         if ( domctl->cmd == XEN_DOMCTL_getvcpuextstate )
             copyback = 1;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.